Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix link for useDefaults #1955

Merged
merged 3 commits into from
Nov 13, 2022
Merged

Conversation

bradjones1
Copy link
Contributor

What issue does this pull request resolve?

I ran into what is essentially #1790, where I was confused that validation failed but the errors property on the validation function was not set. I have tested this and it appears this is due to a missing, but not required, property in the validated object.

What changes did you make?

Fixes a broken link to the option and adds a clarifying note regarding the errors property in this case.

Is there anything that requires more attention while reviewing?

Ensure I'm correct about this behavior :-)

docs/api.md Outdated Show resolved Hide resolved
@epoberezkin
Copy link
Member

I don't think the correction is correct, #1790 was related to ajv v6.

docs/api.md Outdated Show resolved Hide resolved
@epoberezkin epoberezkin changed the title [docs] Clarify validation errors and fix link for useDefaults docs: fix link for useDefaults Nov 13, 2022
@epoberezkin epoberezkin merged commit 5d5c803 into ajv-validator:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants