Check for first property in generated code #2182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkav77
force-pushed
the
serialize-opt-props-only
branch
2 times, most recently
from
13466c2
to
d7831b8
Compare
|
I submitted jsontypedef/json-typedef-spec#15 to add tests for this edge case. |
jkav77
force-pushed
the
serialize-opt-props-only
branch
from
d7831b8
to
cc1a8cc
Compare
|
Looks like this is a duplicate of #2028. I hadn't noticed that before. This is a bit cleaner solution, though... |
|
@epoberezkin This code looks better then mine (#2028), consider merge this PR instead |
|
resolved by #2190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
#2181 -
compileSerializerfails with optional properties onlyWhat changes did you make?
Added a failing test to demonstrate the bug.
Is there anything that requires more attention while reviewing?
No.
fixes #2171
fixes #2181
fixes #2001