build(deps): update Node.js versions for CI builds #2357
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re2 no longer works for NodeJS v14 and thus the CI fails for all new PRs NodeJS v16 has also dropped out of support Fixes ajv-validator#2330
|
Thanks for this. I say let's remove 21.x first, merge and then apply your other fix adding it back. |
|
This has been done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
Fixes #2330
re2 no longer works for NodeJS v14 and thus the CI fails for all new PRs
NodeJS v16 has also dropped out of support
Please note that NodeJS v21 will only work after #2356 has been merged (and the CI in #2356 will fail for NodeJS v14 without this PR). So either merge both regardless of CI or we have to make a commit without v21 first, then merge #2356, then add another PR for v21.