Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: godep #53

Merged
merged 3 commits into from
Aug 15, 2015
Merged

Feature: godep #53

merged 3 commits into from
Aug 15, 2015

Conversation

nicday
Copy link
Contributor

@nicday nicday commented Aug 14, 2015

Saves godeps and provides instructions to restore godeps in readme.

Also simplifies installation instructions by using go get github.com/ajvb/kala (this will install the kala binary to the Go workspace bin directory).

Addresses #52

TODO:

  • Resolve circleci failure

@ajvb
Copy link
Owner

ajvb commented Aug 14, 2015

@nicday Thanks for the PR. Adding Godeps to .gitignore looks like it will fix the Godeps problem. We are using a custom testing binary to easily create a package wide coverprofile that seems to be testing the contents of Godeps.

Igrnore .git when running overalls
@nicday
Copy link
Contributor Author

nicday commented Aug 15, 2015

Godep recommends that you commit the whole Godeps directory, including _workspace.

This allows the ability to isolate dependencies for this project from other dependencies that a developer may have installed in their local $GOPATH. For example, if Kala depends on version 2 of a package and another project the developer is working on depends on version 1 of the same package, they can run godep go [run/build/install] to use the vendored dependencies, without rewriting existing dependencies within your $GOPATH, allowing both projects to use the exact version of the package they depend on.

Instead I have resolved the issue by passing Godeps as ignored directory to Overalls.

However CircleCI is now failing because Coveralls can't find the repo... You may need to have a look at this on your end.

ajvb added a commit that referenced this pull request Aug 15, 2015
@ajvb ajvb merged commit e493239 into ajvb:master Aug 15, 2015
@nicday nicday deleted the feature-godep branch August 15, 2015 04:50
gwoo pushed a commit to gwoo/kala that referenced this pull request Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants