Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaks to linelist pruning #284

Merged
merged 4 commits into from
Mar 22, 2024
Merged

tweaks to linelist pruning #284

merged 4 commits into from
Mar 22, 2024

Conversation

ajwheeler
Copy link
Owner

  • use reduced EW instead of EW, integrate between +- 90 km/s, not 2 A. (Thanks to T. Nordlander for suggestion.)
  • return wavelength extrema of each multiplet
  • clarify that merged lines are wl-sorted, and test that.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (1105e8c) to head (c07cb97).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   89.95%   90.73%   +0.77%     
==========================================
  Files          27       27              
  Lines        2130     2136       +6     
==========================================
+ Hits         1916     1938      +22     
+ Misses        214      198      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajwheeler ajwheeler merged commit 887f5bd into main Mar 22, 2024
9 checks passed
@ajwheeler ajwheeler deleted the improve_prune branch March 22, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant