Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

== extraction accross multiple blocks of text #1

Closed
santiyounger opened this issue Nov 17, 2020 · 7 comments
Closed

== extraction accross multiple blocks of text #1

santiyounger opened this issue Nov 17, 2020 · 7 comments

Comments

@santiyounger
Copy link

Hey, thanks for making this, it has certainly been my most anticipated plugin.

I found a bit of an issue/request

I am extracting big sections of text highlights from a long file.

they are usually parragraphs / multiple blocks of text.

I realized that using == in multiple lines/blocks doesn't detect the extraction correctly into the clipboard.

for instance

== this is a single block highlight. if I keep everything within a single block of text there won't be any problems==

compared to this

==if I split this highlight between multiple lines/blocks

the plugin won't extract it into the clipboard==

if it's not possible to fix this through the syntax of ==equal signs==

perhaps this issue could be solved by also allowing to extract sections of text by using the<mark> tag

<mark>
 this way it's easy to define an opening point

as well as an ending point

accross several blocks of text
</mark>

let me know if it'd be useful to provide more examples, perhaps with obsidian screenshots

thanks for the help, and really appreciate the excellent plugin

@akaalias
Copy link
Owner

Hi Santi! No, this is great. Thank you for letting me know. I'll look into this case soon and keep you posted here.

@santiyounger
Copy link
Author

Thank you, sound good, after looking further into my type of notes, I think the cleanest way to solve this would be to enable the use of <mark> and </mark> for more precision with opening and closing the highlight.

Thanks a lot! Let me know if there's any way I can help

@akaalias
Copy link
Owner

akaalias commented Nov 17, 2020

Hi Santi, I've fixed the issue and will now upload a new release. I personally prefer using == instead of (just for my own way of flow highlighting)

Please note that at least for me, Obsidian doesn't highlight multi-block highlights either (see demo)

Screenshot 2020-11-17 at 18 21 51

@akaalias
Copy link
Owner

Yup, it's in release 0.0.4 - Easily updated via third-party-plugins in Obsidian :)
Screenshot_2020-11-17_at_18_24_21

@santiyounger
Copy link
Author

awesome thank you, works great! and you are right blocks highlights seems to be an Obsidian limitation.

This is why still think <mark> </mark> would really help, I was suggesting it more as an additional way to highlight, yet not a replacment of ==.

it'd be awesome if it were possible to add <mark> as an additional option, but I understand if it's tricky to implement it.

Overall, thanks for taking a look at this, even if highlight isn't correctly showed (due to obsidian's block limitations) the plugin extracts it correctly.

Thank you

@akaalias
Copy link
Owner

akaalias commented Nov 18, 2020

Good news! I've added support to extract highlights by <mark>...</mark> - It's in today's release -> https://github.com/akaalias/extract-highlights-plugin/releases/tag/0.0.5

What's still wonky is how I'm flattening newlines at the moment. So, if you have this:

<mark>
this way it's easy to define an opening point

as well as an ending point

accross several blocks of text
</mark>

I'm currently replacing the newlines with a space. That's not ideal but that'll take some time to figure out.

Anyways, basic support for <mark></mark> is in there. Hope this helps!

Screenshot 2020-11-18 at 09 35 39

@santiyounger
Copy link
Author

thank you so much @akaalias, works great! super happy with it, can't wait to see how this plug in grows. Thank you for speding time adding this feature, means a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants