Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Make it work with <mark> attributes like <mark class="green"> #13

Open
Moonbase59 opened this issue Jun 7, 2021 · 5 comments
Open

FR: Make it work with <mark> attributes like <mark class="green"> #13

Moonbase59 opened this issue Jun 7, 2021 · 5 comments

Comments

@Moonbase59
Copy link

@Moonbase59 Moonbase59 commented Jun 7, 2021

Hi there, and thanks for a useful plugin. I came across a small issue today and wonder if you’d like to fix it.

Currently, the plugin extracts highlights fine for

  • double-equals highlights (==highlight==)
  • text marked with <mark>something</mark>

but it will not extract highlights if the <mark> element has attributes, like <mark class="green"> or <mark style="background-color: pink;">.

Since I showed how to use "compatible" different-colour highlights in the forums today, I’d be grateful if Extract highlights could also handle these.

@akadormouse
Copy link

@akadormouse akadormouse commented Dec 7, 2021

I'd support this request, which is needed for this to work with the Highlightr plgin.

@amitbha
Copy link

@amitbha amitbha commented Feb 9, 2022

#1 seem to be supported already.

@subscribe88
Copy link

@subscribe88 subscribe88 commented Feb 17, 2022

The current plugin v0.0.18 currently is not able to extract with highlights with attributes e.g. . Thank you for helping to make it work.

@amitbha
Copy link

@amitbha amitbha commented Feb 18, 2022

The current plugin v0.0.18 currently is not able to extract with highlights with attributes e.g. . Thank you for helping to make it work.

I know little about js and plugin develop.
But I wrote lua script for my text editor(Textadept) to extract highlights from markdown, supporting bold, highlight, <u>, <mark>, and titles. I can share it if needed.

@xiumuyo
Copy link

@xiumuyo xiumuyo commented Mar 14, 2022

I'd support this request, which is needed for this to work with the Highlightr plgin.

I also agree with this proposal, it will be great useful if it can work with the Highlightr plugin, and extract highlights like: <mark style="background: #6FE26FA6;"> text </mark>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants