#32 #34 Added an icp4 - icp6

akabekobeko · Jun 22, 2016 · de3f595 · de3f595
1 parent 8acc81e
commit de3f595
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/lib/icns-generator.js b/src/lib/icns-generator.js
@@ -9,7 +9,7 @@ export const IcnsConstants = {
    * Sizes required for the ICNS file.
    * @type {Array}
    */
-  imageSizes: [ 32, 64, 128, 256, 512, 1024 ],
+  imageSizes: [ 16, 32, 64, 128, 256, 512, 1024 ],
 
   /**
    * The size of the ICNS header.
@@ -28,6 +28,9 @@ export const IcnsConstants = {
    * @type {Array}
    */
   iconIDs: [
+    { id: 'icp4', size:   16 },
+    { id: 'icp5', size:   32 },
+    { id: 'icp6', size:   64 },
     { id: 'ic07', size:  128 },
     { id: 'ic08', size:  256 },
     { id: 'ic09', size:  512 },
@@ -65,7 +68,8 @@ export default class IcnsGenerator {
       for( let i = 0, max = IcnsConstants.iconIDs.length; i < max; ++i ) {
         const iconID = IcnsConstants.iconIDs[ i ];
         if( !( IcnsGenerator.writeImage( iconID, images, stream ) ) ) {
-          return reject( new Error( 'Faild to read/write image.' ) );
+          reject( new Error( 'Faild to read/write image.' ) );
+          return;
         }
       }
 

diff --git a/test/lib/icns-generator.test.js b/test/lib/icns-generator.test.js
@@ -41,7 +41,7 @@ describe( 'IcnsGenerator', () => {
 
   /** @test {IcnsGenerator#createIconHeader} */
   it( 'createIconHeader', () => {
-    const header = IcnsGenerator.createIconHeader( IcnsConstants.iconIDs[ 0 ], 128 );
+    const header = IcnsGenerator.createIconHeader( IcnsConstants.iconIDs[ 3 ], 128 );
 
     // In ASCII "ic07"
     assert( header.readUInt8( 0 ) === 0x69 );

diff --git a/test/lib/icon-generator.test.js b/test/lib/icon-generator.test.js
@@ -52,7 +52,7 @@ describe( 'IconGenerator', () => {
     assert( expected.length === 7 );
 
     expected = IconGenerator.filter( targets, IcnsConstants.imageSizes );
-    assert( expected.length === 6 );
+    assert( expected.length === 7 );
 
     expected = IconGenerator.filter( targets, FaviconConstants.imageSizes );
     assert( expected.length === 10 );