Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executable file? #113

Closed
makenowjust opened this issue Jul 22, 2019 · 2 comments · Fixed by #115
Closed

Executable file? #113

makenowjust opened this issue Jul 22, 2019 · 2 comments · Fixed by #115
Milestone
v2.1.0

Comments

@makenowjust
Copy link
Contributor

Some files (e.g. README.md, LICENSE, package.json etc.) are marked as "executable file". It looks strange.

スクリーンショット 2019-07-22 21 46 54

I guess this problem comes from Windoes file system.
@akabekobeko
Copy link
Owner

This is not my intention. Certainly README.md etc are not executable files. If possible, change it in the GitHub repository settings.

makenowjust added a commit to makenowjust/npm-icon-gen that referenced this issue Jul 22, 2019
@makenowjust
Fix file permissions
d6f0be1 
Fixed akabekobeko#113

Remove executable flag from files except for `src/bin/index.js` and
`dist/bin/index.js`.
@makenowjust makenowjust mentioned this issue Jul 22, 2019
Merged
@akabekobeko akabekobeko added this to the v2.1.0 milestone Jul 22, 2019
@akabekobeko akabekobeko reopened this Jul 22, 2019
@akabekobeko
Copy link
Owner

akabekobeko commented Jul 22, 2019 •
edited

The file structure has been changed in the develop branch. So I change permissions in my new configuration.

akabekobeko added a commit that referenced this issue Oct 14, 2019
@akabekobeko
#113 Redmove executable permission
7b676e9
akabekobeko added a commit that referenced this issue Oct 14, 2019
@akabekobeko
#113 Remove an executable permission
76f2cab
@akabekobeko akabekobeko modified the milestones: v2.1.0, v3.0.0 Aug 30, 2020
akabekobeko added a commit that referenced this issue Dec 4, 2020
@akabekobeko
#113 Change permission
89e510e
akabekobeko added a commit that referenced this issue Dec 4, 2020
@akabekobeko
#113 Change permission
9c46778
@akabekobeko akabekobeko modified the milestones: v3.0.0, v2.1.0 Dec 4, 2020
@akabekobeko akabekobeko mentioned this issue Dec 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Fix file permissions makenowjust/npm-icon-gen
2 participants
@akabekobeko @makenowjust