Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the ".ico" file generation #4

Closed
akabekobeko opened this issue Jan 23, 2016 · 2 comments
Closed

Implement the ".ico" file generation #4

akabekobeko opened this issue Jan 23, 2016 · 2 comments
Milestone
v1.0.0

Comments

@akabekobeko
Copy link
Owner

@akabekobeko akabekobeko added this to the v1.0.0 milestone Jan 23, 2016
akabekobeko added a commit that referenced this issue Jan 25, 2016
@akabekobeko
#4 Implement a conversion from png to ico
26c5a80
akabekobeko added a commit that referenced this issue Jan 26, 2016
@akabekobeko
#4 Fixed writing bug ico file
ff16891
akabekobeko added a commit that referenced this issue Feb 3, 2016
@akabekobeko
#4 Change the definition of a constant
5df3ed0
akabekobeko added a commit that referenced this issue Feb 8, 2016
@akabekobeko
#4 Implement the ico file generation
0be0850 
But, Color and orientation of the image is incorrect.
akabekobeko added a commit that referenced this issue Feb 8, 2016
@akabekobeko
#4 Delete unnecessary files
96efd0e
@akabekobeko
Copy link
Owner Author

  • Color that invalid is pngjs might cause
  • Orientation of invalid in the case of DIB, because the origin is in the lower left corner

@akabekobeko
Copy link
Owner Author

Bug is fixed in the #9 and #10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@akabekobeko