-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change to sharp #136
change to sharp #136
Conversation
to allow removing unmaintained phantomjs
I tested it on my icons for https://github.com/mifi/lossless-cut and the icons look roughly the same (not pixel exact but very similar) |
Thank you! Check it out this weekend. |
@mifi
Are there any settings to avoid this problem? svg2png sharp |
I updated the code now, so it should now generate those correctly here's how i ran it: npm run watch
cd dist/bin
node . -i ../../examples/data/sample.svg -o ../../examples/data/ --icns --favicon |
I also confirm it still works with my project https://github.com/mifi/lossless-cut after these changes (generates the same icons) |
@mifi |
great! thanks for making this module btw. all these different icon standards is a jungle so it's nice to have one package to generate all of them from svg. |
See #135