Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary uuid lib #158

Merged
merged 1 commit into from May 27, 2023
Merged

Removed unnecessary uuid lib #158

merged 1 commit into from May 27, 2023

Conversation

panther7
Copy link
Contributor

No description provided.

akabekobeko
akabekobeko reviewed May 25, 2023
View reviewed changes
Copy link
Owner

@akabekobeko akabekobeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Good suggestion to reduce deps!
I have commented that it would be better to change only the temporary directory name specification.

src/lib/index.ts Show resolved Hide resolved
src/lib/png.test.ts Show resolved Hide resolved
src/lib/index.ts Outdated Show resolved Hide resolved
@akabekobeko akabekobeko self-assigned this May 25, 2023
@akabekobeko akabekobeko added this to the v4.0.0 milestone May 25, 2023
@panther7
Copy link
Contributor Author

Done

akabekobeko
akabekobeko approved these changes May 27, 2023
View reviewed changes
Copy link
Owner

@akabekobeko akabekobeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akabekobeko akabekobeko merged commit 2c27a37 into akabekobeko:main May 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akabekobeko akabekobeko akabekobeko approved these changes

Assignees

@akabekobeko akabekobeko

Labels
refactor
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@panther7 @akabekobeko