Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icns generation #43

Merged
merged 2 commits into from
Nov 7, 2016
Merged

Fix icns generation #43

merged 2 commits into from
Nov 7, 2016

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Nov 5, 2016

See #42.
Don't know why retina icons (ic11-14) breaks the icns file, but when I remove them it's working.

@mifi
Copy link
Contributor Author

mifi commented Nov 5, 2016

Travis CI build failed. I have now also fixed version of svg2png dependency to 3.1.0 because 3.1.1 introduced the breaking change of no longer supporting node 4. This can be reverted when svg2png releases a fix of the breaking change or if npm-icon-gen starts requiring minimum node 6.
See also domenic/svg2png#70

@akabekobeko
Copy link
Owner

@mifi

Thank you PR.

By the way, in the test of Travis CI has been under consideration to be in the Node version v6 and v7, or it is better that you also support v4?

@mifi mifi mentioned this pull request Nov 6, 2016
@mifi
Copy link
Contributor Author

mifi commented Nov 6, 2016

In my opinion v4 should still be supported because lots of people still use it, and it's still official LTS. However it looks like domenic (author of svg2png) doesn't want to cooperate and fix his broken 3.1.1 version, so we have to either force v6 or set version of the svg2png dependency to =3.1.0

@akabekobeko akabekobeko merged commit ce581ff into akabekobeko:master Nov 7, 2016
@akabekobeko
Copy link
Owner

@mifi

Thank you for the comment.

In order to apply the bugfix future of svg2png must be dropped Node v4 support.
For the svg2png equivalent of function is difficult to implement in this tool, Node v4 support gives up.

@mifi
Copy link
Contributor Author

mifi commented Nov 7, 2016

Yes, when v4 support is dropped you should publish a new major version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants