Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close a write stream #57

Merged
merged 1 commit into from
May 7, 2017

Conversation

MatchaChoco010
Copy link
Contributor

write streamを明示的に閉じるようにしました。

@MatchaChoco010
Copy link
Contributor Author

ストリームを閉じない場合、以下のgulpでエラーが出ました。
実行環境はwindows10です。

const gulp = require('gulp');
const icongen = require('icon-gen');
const packager = require('electron-packager');

const iconOption = {
  modes: ['ico', 'icns'],
  names: {
    ico: 'icon',
    icns: 'icon',
  },
};
gulp.task(
  'icon-gen',
  () => icongen('./src/assets/icon.svg', './tmp/', iconOption)
);

const packagerOption = {
  dir: './app/',
  arch: 'all',
  asar: true,
  icon: './tmp/icon',
  out: './dist',
  platform: ['win32', 'darwin', 'linux'],
};
gulp.task(
  'default',
  ['icon-gen'],
  cb => packager(packagerOption, cb)
);

Error: rcedit.exe failed with exit code 1. Fatal error: Unable to set icon

@akabekobeko akabekobeko added the fix label May 7, 2017
@akabekobeko akabekobeko added this to the v1.1.3 milestone May 7, 2017
@akabekobeko akabekobeko merged commit cffa6a8 into akabekobeko:master May 7, 2017
@akabekobeko
Copy link
Owner

ありがとうございます。merge させていただきました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants