Update axios + other housekeeping #54
Conversation
Primary chance is upgrading to Axios 1.x. Also includes some housekeeping on dev-dependencies & docs.
| }, | ||
| "dependencies": { | ||
| "axios": "^0.21.1", | ||
| "tslib": "^2.3.0", | ||
| "axios": "^1.6.8", |
There was a problem hiding this comment.
Should this be a major version bump for our Package?
Does it have potential to break things such as args passed in, or middlewares?
There was a problem hiding this comment.
We only expose a fairly limited subset of native axios options, the most significant of which is adapter, which doesn't appear to have any breaking API changes as far as I can tell. That would indicate that we're maintaining API compatibility, so a minor version bump should be sufficient.
However, we specifically added the adapter param to support axios-fetch-adaptor for use in environments like the CloudFlare worker runtime which doesn't implement the necessary APIs for axios to run natively. It looks like this isn't compatible with axios 1.x, not due to API compatibility, but changes in import paths in the axios peer-dependency. That would mean that the new version of our package does break this use-case, and because we're specifying axios as a dependency rather than peer-dependency, I'm not sure whether npm would be smart enough to find the right combination of package versions to maintain compatibility.
Primary change is upgrading to Axios 1.x.
Also includes some housekeeping on dev-dependencies & docs.