Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make videos look less shit. (#151) #153

Closed
wants to merge 1 commit into from

Conversation

solonovamax
Copy link
Contributor

Changes the noise to use channel 0, aka the luminosity channel, making it looks less shit.

Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>
@akai-katto akai-katto self-assigned this Oct 25, 2020
@akai-katto akai-katto self-requested a review October 25, 2020 21:29
@akai-katto
Copy link
Owner

I'm currently working on a dandere2x overhaul, and adding this in to the next build / testing it out is on my radar.

A lot is fundementally changing behind the scenes so the MR will be on hold until then.

Thanks for the contribution! This is a starting point for me to investigate the roles of color formats in relation to dandere2x - I've sort of been ignoring it up until now

@akai-katto
Copy link
Owner

Working on this now - there's merge conflicts but reviewing it (after many many many months grr)

@akai-katto
Copy link
Owner

Unfortunately, this was submitted at a weird time in my life where I was moving out / I was assigned a new work project and put on crunch time, while dandere2x was going through an architecture overhaul. After months later, I've had the time to try this out, and I made the changes you proposed and put it into master.

I labeled you as a co-contributor, if you want I can give more contribution credit, but I did this to save myself from having to re-ask you to commit after many months later.

https://github.com/akai-katto/dandere2x/blob/master/src/config_files/output_options.yaml

@akai-katto akai-katto closed this Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants