Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdin mode #306

Merged
merged 7 commits into from
Feb 11, 2023
Merged

stdin mode #306

merged 7 commits into from
Feb 11, 2023

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Feb 24, 2022 •
edited
Loading

Fixes #239.

  • Design decision: --stdin-filename vs. unique file in the src argument with an --stdin option (see discussion in #239)
    • Add --stdin-filename command line argument, or
    • Ensure unique file in src
  • Ensure rev2 == ":WORKTREE:"
  • Ensure no positional file arguments
  • Read stdin instead of file
  • Raise NotImplementedError if both --stdin-filename and --lint are used (we may fix this later)
  • Make HEAD..:STDIN: the default if --stdin-filename is used
  • Merge Run linters twice: 1) baseline, 2) current; then show new messages #393
  • Improve --revision description in --help
  • Update --help in README.rst
  • Change log
  • Tests
    • all 8 combinations of existence of src = config option, path/directory on command line, and --stdin-filename

@akaihola akaihola added the enhancement New feature or request label Feb 24, 2022
@akaihola akaihola added this to the 1.6.0 milestone Feb 24, 2022
@akaihola akaihola added this to In progress in Akaihola's Open source work via automation Feb 24, 2022
@akaihola akaihola self-assigned this Feb 24, 2022
@akaihola akaihola marked this pull request as draft February 24, 2022 11:05
@akaihola akaihola force-pushed the stdin-filepath branch 2 times, most recently from 7be6ecd to 917a715 Compare February 27, 2022 14:38
@akaihola akaihola force-pushed the stdin-filepath branch 3 times, most recently from 0bdec8d to 3cda4fe Compare March 14, 2022 17:50
@akaihola akaihola force-pushed the stdin-filepath branch 3 times, most recently from 7633b63 to e54e592 Compare March 26, 2022 21:42
@akaihola akaihola force-pushed the stdin-filepath branch 5 times, most recently from 4b26c64 to 48be4ab Compare April 5, 2022 16:55
@akaihola akaihola force-pushed the stdin-filepath branch 3 times, most recently from 2bb030b to eb5a9fc Compare April 10, 2022 12:35
@akaihola akaihola force-pushed the stdin-filepath branch 2 times, most recently from bc7f705 to 57cd9e3 Compare April 27, 2022 06:44
@akaihola akaihola force-pushed the stdin-filepath branch 4 times, most recently from 2acce16 to d5b2b0c Compare August 30, 2022 06:21
@akaihola akaihola added the help wanted Extra attention is needed label Sep 17, 2022
@akaihola akaihola removed this from the 1.6.0 milestone Sep 17, 2022
@akaihola akaihola force-pushed the stdin-filepath branch 3 times, most recently from b985001 to 0a803dd Compare January 6, 2023 22:28
@akaihola

This comment was marked as resolved.

Sign in to view
@akaihola akaihola force-pushed the stdin-filepath branch 3 times, most recently from ec4ee44 to 8d1d90f Compare January 13, 2023 19:28
@akaihola akaihola force-pushed the stdin-filepath branch 2 times, most recently from f229026 to 15d8a0a Compare January 15, 2023 21:17
@akaihola akaihola force-pushed the stdin-filepath branch 2 times, most recently from bae510f to 5179baa Compare January 22, 2023 21:02
@akaihola akaihola marked this pull request as ready for review January 30, 2023 20:40
@akaihola
Copy link
Owner Author

Hey @qubidt, would you be interested to review the implementation for this feature? Feel free to accept my invitation as a contributor to this repository if you'd like to be marked as reviewer on GitHub as well.

@akaihola
Copy link
Owner Author

akaihola commented Feb 4, 2023

@chmouel I remember you documented how to use Darker with emacs-reformatter – I wonder if stdin mode would be useful there? Would you be interested to review this PR?

@akaihola
Copy link
Owner Author

akaihola commented Feb 4, 2023

Also @Krischtopp & @Carreau didn't we discuss issues with Darker in VSCode and Vim in #104? Could stdin mode help there? Would either of you two be interested to review this PR?

@akaihola akaihola merged commit adfa90e into master Feb 11, 2023
@akaihola akaihola deleted the stdin-filepath branch February 11, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Awaiting requested review from Carreau

@Krischtopp Krischtopp Awaiting requested review from Krischtopp

Assignees

@akaihola akaihola

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Darker and Graylint development
Status: No status
Akaihola's Open source work
  
In progress
Milestone
Darker 1.7.0
Development

Successfully merging this pull request may close these issues.

Can't read a file on standard input
1 participant
@akaihola