Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow - as SRC when using --stdin-filename #494

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Allow - as SRC when using --stdin-filename #494

merged 3 commits into from
Jun 5, 2023

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented May 28, 2023 •
edited
Loading

@akaihola akaihola added the bug Something isn't working label May 28, 2023
@akaihola akaihola added this to the Darker 1.7.2 milestone May 28, 2023
@akaihola akaihola self-assigned this May 28, 2023
@akaihola
Copy link
Owner Author

@my-tien could you review this pull request? Can I add you as a collaborator on this repository and assign the review to you?

@my-tien
Copy link
Collaborator

my-tien commented May 28, 2023

Yes, you can assign me

@my-tien my-tien assigned my-tien and akaihola and unassigned akaihola and my-tien May 29, 2023
@my-tien my-tien self-requested a review May 29, 2023 08:43
@akaihola
Copy link
Owner Author

Thanks @my-tien for the review. Merging this is now blocked by #495.

@akaihola
Copy link
Owner Author

@my-tien I created fixes for #495 in

Is it possible for you to review those as well?

@akaihola akaihola mentioned this pull request May 31, 2023
Merged
@akaihola
Failing test for --stdin-filename=<path> -
6ecafca
@akaihola
Allow single - as SRC with --stdin-filename
fe1fe0f 
This makes Darker behave like Black. It will also work without the
hyphen as the SRC filename unlike Black, though.
@akaihola
Update the change log
b0ac3f5
@akaihola akaihola enabled auto-merge June 5, 2023 20:56
@akaihola akaihola merged commit 1e139d2 into master Jun 5, 2023
39 checks passed
@akaihola akaihola deleted the hyphen-as-src branch June 5, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@my-tien my-tien my-tien approved these changes

Assignees

@akaihola akaihola

Labels
bug Something isn't working
Projects
Darker and Graylint development
Archived in project
Milestone
Darker 1.7.2
Development

Successfully merging this pull request may close these issues.

- as source file not allowed when using the --stdin-filename option (unlike in Black)
2 participants
@akaihola @my-tien