Use return value 1 always if there are linter errors
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaihola
force-pushed
the
error-retval
branch
2 times, most recently
from
3d7c8db
to
c303b89
Compare
akaihola
force-pushed
the
error-retval
branch
2 times, most recently
from
31ba566
to
e99202a
Compare
Used to return the number of linter errors. Didn't make sense as a shell return value.
Pytest will get confused otherwise:
================================ ERRORS ================================
___________ ERROR collecting src/graylint/tests/test_main.py ___________
import file mismatch:
imported module 'test_main' has this __file__ attribute:
/home/akaihola/prg/graylint/action/tests/test_main.py
which is not the same as the test file we want to collect:
/home/akaihola/prg/graylint/src/graylint/tests/test_main.py
HINT: remove __pycache__ / .pyc files and/or use a unique basename for
your test file modules
======================= short test summary info ========================
ERROR src/graylint/tests/test_main.py
!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6