Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SVGAnimatedString #333

Closed
wants to merge 1 commit into from

Conversation

liufei
Copy link

@liufei liufei commented Jan 29, 2022

Uncaught TypeError: e.match is not a function

SVGAnimatedString

@SaschaBrechmannVHV
Copy link

Hi @bluesmoon , @ceckoslab , @andreas-marschke , @ashenoy2014 , @nicjansma
could this PR be Merged ?

Regards, Sascha

@ashenoy2014
Copy link

ashenoy2014 commented May 4, 2023

@liufei @SaschaBrechmannVHV Thank you for the changes. We will take a look soon. In the mean time, have you thought about what sort of test can be added to cover this? If you can, that would be super helpful!

@nicjansma
Copy link

nicjansma commented May 18, 2023

Thanks for opening this PR @liufei. I've added a test (in our internal repo), and will backport it here shortly. Since I can't push to your remote, I'll commit to our main branch and close this PR out once it's available.

@liufei
Copy link
Author

liufei commented May 18, 2023

@ashenoy2014 @nicjansma You're welcome. Due to the incompatibility of the MacBook Pro M1 chip with e2e testing, there is currently no solution available, and therefore the test has not been submitted.

@SaschaBrechmannVHV Although the PR won't be merged, I appreciate your attention to this issue and hope that all Lottie users won't be affected by this problem and can still use Boomerang normally.

@nicjansma
Copy link

Merged in with 9e7063e

Thanks @liufei !

@nicjansma nicjansma closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants