Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate EwId in command update-id #115

Merged
merged 1 commit into from
Dec 20, 2022
Merged

validate EwId in command update-id #115

merged 1 commit into from
Dec 20, 2022

Conversation

kyleli-akamai
Copy link
Collaborator

@kyleli-akamai kyleli-akamai commented Dec 20, 2022 •
edited
Loading

Major Changes

  • Added a helper function to check if the ewId is valid.
  • Fixed the error message when updating an ewId with wrong format.

Test Result

image

@kyleli-akamai kyleli-akamai changed the base branch from master to develop December 20, 2022 18:03
@kyleli-akamai kyleli-akamai merged commit 124bc83 into develop Dec 20, 2022
@kyleli-akamai kyleli-akamai deleted the bugfix/EW-14861 branch December 20, 2022 20:14
swathimr pushed a commit that referenced this pull request Jan 31, 2023
@hkambham
code to enable the vscode and intelliJ plugins headers to track pendo…
a1b193d 
… events in portal-api (#119)

* added IDE extension header
* validate EwId in command update-id (#115)
* Bump json5 from 2.2.1 to 2.2.3
* update year in copyright text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmatthew bmatthew bmatthew approved these changes

@slukic0 slukic0 slukic0 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyleli-akamai @bmatthew @slukic0