egcurl: bug fix for refactoring from Dec. 2015 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egcurl: improve logging, modularity, readability, and formatting
|
Could you please merge in the current master and add your changes back? The previous commit broke existing functionality. Without tests this is a challenge to deal with, and the number of conflicts is many. Thanks, |
|
Note that I'm manually merging the changes. It'll be re-merged shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream reverted the previous code cleanup but didn't provide comments or feedback what went wrong.
However in further development I found that the
get_relative_urlfunction did not include the query parameters in the signature calculation.The issue could appear when using APIs such as
/network-list/v1/network_lists/unique-id/activate?env=envwhich hadGETparameters on them.