DA Update Library - POST to Repository #6
Conversation
src/Alert.jl
Outdated
| ################################################### | ||
| # | ||
| # Copyright © Akamai Technologies. All rights reserved. | ||
| # Proprietary and confidential. |
There was a problem hiding this comment.
take this out. it's opensource, so it's neither proprietary nor confidential
There was a problem hiding this comment.
deleted # Proprietary and confidential.. Should we delete Copyright... as well?
There was a problem hiding this comment.
No we most definitely want to keep the copyright. All opensource code has a copyright otherwise you can't license it.
This is what it should look like:
###################################################
#
# Copyright 2016 SOASTA, Inc.
# Distributed under the terms of the MIT license
#
# File: RepositoryAPI.jl
#
# Functions to communicate with the mPulse Repository REST API
# This file MUST be `include()`d from `mPulseAPI.jl`
#
###################################################
src/Alert.jl
Outdated
| postRepositoryAlert | ||
|
|
||
| """ | ||
|
|
src/Alert.jl
Outdated
| `token::AbstractString` | ||
| : The Repository authentication token fetched by calling [`getRepositoryToken`](@ref) | ||
|
|
||
| #### Optional Arguments |
There was a problem hiding this comment.
Change this to Keyword Arguments. Also, you need to add alertName
There was a problem hiding this comment.
were the fixes pushed? I don't see them here.
There was a problem hiding this comment.
hm, it should be pushed?
bos-mpkgb:DA_mPulseAPI amisingh$ git push origin DA_update_library
Counting objects: 8, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 1.18 KiB | 1.18 MiB/s, done.
Total 8 (delta 6), reused 0 (delta 0)
remote: Resolving deltas: 100% (6/6), completed with 3 local objects.
To https://github.com/amsingh17/mPulseAPI.jl.git
7628e8e..6f5caca DA_update_library -> DA_update_library
src/Alert.jl
Outdated
| : The alert's name | ||
|
|
||
| `tenantID::Int64` | ||
| : The ID of the tenant in which the alert is in |
There was a problem hiding this comment.
tenant that the alert is in
…rror thrown after retries
The following changes address Amit's first Wrike task in the Dynamic Alerting project - POST to Repository.