Implement the function to close modal with ESC key #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin21
changed the title
sachin21
force-pushed
the
implement_the_function_to_close_modal_with_esc
branch
from
ce06fa2
to
e209af7
Compare
|
@akameco レビューお願いします 🙏 |
akameco
reviewed
Nov 1, 2018
| } | ||
|
|
||
| componentDidMount() { | ||
| window.addEventListener('keydown', this.escToClose.bind(this), false) |
There was a problem hiding this comment.
お、不要だったら修正pull-req送ります！みますー 🙏
There was a problem hiding this comment.
あ、すみません！修正してくださったんですね、ありがとうございます。
|
@sachin21 PRありがとうございます！ 一つ確認してもらえれば 🙏 |
|
v1.1.0 としてリリースしました 🎉 次の起動時に自動更新されるはずです |
|
ありがとうございますー！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #173
What:
画像のプレビュー機能をESCキーで閉じる機能を実装します。。
Why:
人類はESCで閉じる習慣があると思うので、ESCで閉じれないのは多少の不便を感じていました。
How:
windowにkeydowneventをlistenさせ、27番(ESC)が押されたら画像のプレビューを閉じますChecklist:
Electron appでkeydownをlistenするbest practiceを知らないので、そこらへん含みレビュー頂きたいですー 🙏