Refactor

akameco · Nov 7, 2017 · 3052328 · 3052328
1 parent 8ed8dee
commit 3052328
Showing 1 changed file with 25 additions and 33 deletions.
diff --git a/src/index.js b/src/index.js
@@ -73,12 +73,9 @@ const isValidate = (path: Object, state: State): boolean => {
     return false
   }
 
-  const messagesObj = path.get('arguments')[0]
+  const msgPath = path.get('arguments.0')
 
-  if (
-    !messagesObj ||
-    !(messagesObj.isObjectExpression() || messagesObj.isIdentifier())
-  ) {
+  if (!msgPath || !(msgPath.isObjectExpression() || msgPath.isIdentifier())) {
     return false
   }
 
@@ -156,11 +153,10 @@ const replaceProperties = (
   }
 }
 
-const getExportName = (
-  namedExport,
-  defaultExport,
-  includeExportName
-): string | null => {
+const getExportName = (path, includeExportName): string | null => {
+  const namedExport = path.findParent(v => v.isExportNamedDeclaration())
+  const defaultExport = path.findParent(v => v.isExportDefaultDeclaration())
+
   if (includeExportName && namedExport) {
     return namedExport.get('declaration.declarations.0.id.name').node
   }
@@ -172,6 +168,20 @@ const getExportName = (
   return null
 }
 
+function getProperties(path): $ReadOnlyArray<Object> | null {
+  if (path.isObjectExpression()) {
+    return path.get('properties')
+  } else if (path.isIdentifier()) {
+    const { name } = path.node
+    const obj = path.scope.getBinding(name)
+    if (!obj) {
+      return null
+    }
+    return obj.path.get('init.properties')
+  }
+  return null
+}
+
 export default function() {
   return {
     name: 'react-intl-auto',
@@ -181,31 +191,13 @@ export default function() {
           return
         }
 
-        const namedExport = path.findParent(v => v.isExportNamedDeclaration())
-        const defaultExport = path.findParent(v =>
-          v.isExportDefaultDeclaration()
-        )
-        const exportName = getExportName(
-          namedExport,
-          defaultExport,
-          state.opts.includeExportName || false
-        )
-        const messagesObj = path.get('arguments')[0]
-
-        let properties
-
-        if (messagesObj.isObjectExpression()) {
-          properties = messagesObj.get('properties')
-        } else if (messagesObj.isIdentifier()) {
-          const { name } = messagesObj.node
-          const obj = messagesObj.scope.getBinding(name)
-          if (!obj) {
-            return
-          }
-          properties = obj.path.get('init').get('properties')
-        }
+        const properties = getProperties(path.get('arguments.0'))
 
         if (properties) {
+          const exportName = getExportName(
+            path,
+            state.opts.includeExportName || false
+          )
           replaceProperties(properties, state, exportName)
         }
       },