refactor: update test

* test: remove slash

* test: add cases function

* refactor: use ||

* chore(npm): remove slash

* chore(prettier): ignore coverage

.prettierignore

@@ -1,2 +1,3 @@
 **/flow-typed/**
+coverage
 lib

package.json

@@ -64,7 +64,6 @@
     "husky": "^0.14.3",
     "jest": "^21.2.1",
     "lint-staged": "^6.0.0",
-    "prettier": "^1.9.2",
-    "slash": "^1.0.0"
+    "prettier": "^1.9.2"
   }
 }

src/__tests__/index.test.js

@@ -1,15 +1,9 @@
 // @flow
 import path from 'path'
-import slash from 'slash'
 import pluginTester from 'babel-plugin-tester'
 import plugin from '../'
 
-const filename = path.resolve(
-  slash(__dirname),
-  '..',
-  '__fixtures__',
-  'messages.js'
-)
+const filename = path.resolve(__dirname, '..', '__fixtures__', 'messages.js')
 
 const defaultTest = {
   title: 'default',
@@ -232,77 +226,73 @@ export default defineMessages({
   leadingCommentWithDescriptionTest,
 ]
 
-type PTestOpts = {
-  title: string,
-  tests: $ReadOnlyArray<{ title: string, code: string }>,
-}
-
-function pTest(opts: PTestOpts) {
+cases([
+  { title: 'default', tests },
+  {
+    title: 'removePrefix = "src"',
+    tests: [defaultTest],
+    pluginOptions: { removePrefix: 'src' },
+  },
+  {
+    title: 'removePrefix = "src/" -- with slash',
+    tests: [defaultTest],
+    pluginOptions: { removePrefix: 'src/' },
+  },
+  {
+    title: 'filebase = true',
+    tests: [defaultTest],
+    pluginOptions: { filebase: true },
+  },
+  {
+    title: 'includeExportName = true',
+    tests: [defaultTest, multiExportTest],
+    pluginOptions: { includeExportName: true },
+  },
+  {
+    title: 'includeExportName = all',
+    tests: [defaultTest, multiExportTest],
+    pluginOptions: { includeExportName: 'all' },
+  },
+  {
+    title: 'removePrefix = true, includeExportName = true',
+    tests: [defaultTest, multiExportTest],
+    pluginOptions: { removePrefix: true, includeExportName: true },
+  },
+  {
+    title: 'removePrefix = false',
+    tests: [defaultTest, multiExportTest],
+    pluginOptions: { removePrefix: false },
+  },
+  {
+    title: 'removePrefix = true, includeExportName = all',
+    tests: [defaultTest, multiExportTest],
+    pluginOptions: { removePrefix: true, includeExportName: 'all' },
+  },
+  {
+    title: 'extractComments = false',
+    tests: [defaultTest, leadingCommentTest, leadingCommentWithDescriptionTest],
+    pluginOptions: { extractComments: false },
+  },
+])
+
+function cases(
+  testCases: {
+    title: string,
+    tests: $ReadOnlyArray<{ title: string, code: string }>,
+  }[]
+) {
   const defaultOpts = {
     title: '',
     plugin,
     snapshot: true,
     babelOptions: { filename },
     tests: [],
   }
-  opts.tests = opts.tests.map(t => {
-    return { ...t, title: `${opts.title} - ${t.title}` }
-  })
-  pluginTester({ ...defaultOpts, ...opts })
+  for (const testCase of testCases) {
+    testCase.tests = testCase.tests.map(t => ({
+      ...t,
+      title: `${testCase.title} - ${t.title}`,
+    }))
+    pluginTester({ ...defaultOpts, ...testCase })
+  }
 }
-
-pTest({ title: 'default', tests })
-
-pTest({
-  title: 'removePrefix = "src"',
-  tests: [defaultTest],
-  pluginOptions: { removePrefix: 'src' },
-})
-
-pTest({
-  title: 'removePrefix = "src/" -- with slash',
-  tests: [defaultTest],
-  pluginOptions: { removePrefix: 'src/' },
-})
-
-pTest({
-  title: 'filebase = true',
-  tests: [defaultTest],
-  pluginOptions: { filebase: true },
-})
-
-pTest({
-  title: 'includeExportName = true',
-  tests: [defaultTest, multiExportTest],
-  pluginOptions: { includeExportName: true },
-})
-
-pTest({
-  title: 'includeExportName = all',
-  tests: [defaultTest, multiExportTest],
-  pluginOptions: { includeExportName: 'all' },
-})
-
-pTest({
-  title: 'removePrefix = true, includeExportName = true',
-  tests: [defaultTest, multiExportTest],
-  pluginOptions: { removePrefix: true, includeExportName: true },
-})
-
-pTest({
-  title: 'removePrefix = false',
-  tests: [defaultTest, multiExportTest],
-  pluginOptions: { removePrefix: false },
-})
-
-pTest({
-  title: 'removePrefix = true, includeExportName = all',
-  tests: [defaultTest, multiExportTest],
-  pluginOptions: { removePrefix: true, includeExportName: 'all' },
-})
-
-pTest({
-  title: 'extractComments = false',
-  tests: [defaultTest, leadingCommentTest, leadingCommentWithDescriptionTest],
-  pluginOptions: { extractComments: false },
-})

src/index.js

@@ -72,15 +72,11 @@ const isLiteral = node => t.isStringLiteral(node) || t.isTemplateLiteral(node)
 
 const isValidate = (path: Object, state: State): boolean => {
   const callee = path.get('callee')
-  if (!callee.isIdentifier()) {
-    return false
-  }
-
-  if (!isImportLocalName(callee.node.name, state)) {
-    return false
-  }
-
-  if (!path.get('arguments.0')) {
+  if (
+    !callee.isIdentifier() ||
+    !isImportLocalName(callee.node.name, state) ||
+    !path.get('arguments.0')
+  ) {
     return false
   }