Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade react-intl to 3.1.1 #71

Merged
merged 1 commit into from
Aug 8, 2019
Merged

refactor: upgrade react-intl to 3.1.1 #71

merged 1 commit into from
Aug 8, 2019

Conversation

remcohaszing
Copy link
Contributor

@remcohaszing remcohaszing commented Aug 8, 2019

react-intl now includes their own typings, so @types/react-intl was removed.
The typings have been updated to use these new typings.

What: react-intl was upgraded to ^3.1.1

Why: The typings provided by this plugin no longer work with react-intl@^3

How: react-intl was upgraded, @types/react-intl was removed, and the typings were fixed.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

This may be considered a breaking change. No code has changed, but the updated typings no longer work for react-intl@^2.

`react-intl` now includes their own typings, so `@types/react-intl` was removed.
The typings have been updated to use these new typings.
@akameco
Copy link
Owner

akameco commented Aug 8, 2019

@remcohaszing Great work 👍After merging this, we will update the major version and release it.

@akameco akameco merged commit 4e9e88a into akameco:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants