Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort keys when output is not flat #66

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Conversation

toshitanian
Copy link
Contributor

@toshitanian toshitanian commented Feb 27, 2020

what

出力がflatでない時に a-z 順ではなく、文字列の長さ順でソートされていたので、a-z 順で出力できるオプションを追加しました。

Why

展開する時に可読性が悪かったからです。

How:

オプションがついているときに、sortKeyをして返すようにしました。

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@toshitanian toshitanian changed the title Add --sort-when-not-flat option as keys were not sorted in flat mode [WIP] Add --sort-when-not-flat option as keys were not sorted in flat mode Feb 27, 2020
@toshitanian toshitanian changed the title [WIP] Add --sort-when-not-flat option as keys were not sorted in flat mode Add --sort-when-not-flat option as keys were not sorted in flat mode Feb 28, 2020
@toshitanian
Copy link
Contributor Author

こちらの環境では問題ありませんでした。よろしくお願いします

@akameco
Copy link
Owner

akameco commented Mar 2, 2020

@toshitanian PRありがとうございます 😄
こちらはデフォルトの挙動のほうが迷いがなくてよさそうですね。オプションを外してデフォルトの挙動に変更していただけますか?
破壊的変更になりますが、取り込んだらメジャーバージョンを上げてリリースしようと思います 🚀

@toshitanian
Copy link
Contributor Author

toshitanian commented Mar 2, 2020

@akameco はい!修正します!

@toshitanian
Copy link
Contributor Author

@akameco 修正しました!よろしくお願いします〜

@toshitanian toshitanian changed the title Add --sort-when-not-flat option as keys were not sorted in flat mode Sort keys when output is flat Mar 2, 2020
@toshitanian toshitanian changed the title Sort keys when output is flat Sort keys when output is not flat Mar 2, 2020
@akameco akameco merged commit a8aca40 into akameco:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants