Customizable Help Functions #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Designed to begin addressing issue akamensky#29 HelpFunc added as field for Parsers and Commands Parser HelpFunc defaults to Usage unless overwritten Command HelpFunc defaults to first non nil parent HelpFunc Design choice to enable backwards compatibility required exposing Command and arg fields with Getter functions and an interface. Does not resolve: exiting program on help invocation overwrritting/disabling -h | --help argument strings enabling other argument strings to invoke help
akamensky
requested changes
Oct 3, 2019
There was a problem hiding this comment.
@densestvoid thank you for PR. Appreciate the help on this one. I left some review comments there, specifically local imports are failing tests right now.
Resolving PR Changes
Fixed missed change from Command -> *Command as HelpFunc parameter Examples may not pass until PR is intergrated into master, since it includes new functions and fields
|
Changes committed, all checks have passed |
akamensky
approved these changes
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designed to begin addressing issue #29
HelpFunc added as field for Parsers and Commands
Parser HelpFunc defaults to Usage unless overwritten
Command HelpFunc defaults to first non nil parent HelpFunc unless overwritten
Design choice to enable backwards compatibility required
exposing Command and arg fields with Getter functions and an interface.
Does not resolve:
exiting program on help invocation
overwrritting/disabling -h | --help argument strings
enabling other argument strings to invoke help