panic on addArg failure, and tests to check it #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goofinator
commented
Jan 19, 2020
| @@ -441,7 +501,7 @@ func TestFailCaseSensitive(t *testing.T) { | |||
| testArgs := []string{"progname", "-F"} | |||
|
|
|||
| p := NewParser("", "description") | |||
| _ = p.Flag("f", "", &Options{Required: true}) | |||
There was a problem hiding this comment.
Tries to test case sensitivity, but actually - the undefined argument check because of silent argument drop
There was a problem hiding this comment.
as far as I remember long name should be required one and short name is optional. that should be in godoc or in readme.
There was a problem hiding this comment.
Yeah. And here only a shortened argument was provided.
| @@ -1362,7 +1684,7 @@ func TestUsageHidden1(t *testing.T) { | |||
| _ = cmd1.Flag("a", "verylongflagA", &Options{Required: true, Help: "flag1 description"}) | |||
| _ = p.String("s", "verylongstring-flag1", &Options{Help: "string1 description"}) | |||
| _ = p.Int("i", "integer-flag1", &Options{Help: "integer1 description"}) | |||
| _ = p.Int("i2", "integer-flag2", &Options{Help: DisableDescription}) | |||
There was a problem hiding this comment.
Description disabled because of "i2" - long shorthand argument and silent drop of argument, not because of DisableDescription.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is something like this normal to test addArg success?
By the way: after adding this check, 2 errors occurred in the test functions.
1 - no long name, while Case sensitivity was tested.
2 - short name "i1".