[Pull request] I think this will make it look better #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think too many empty lines looks not good, so the updated version may have a better looking like this: $ ./main usage: East [-h|--help] [-d|--dirpath "<value>"] description: sreach engine on file system arguments: -h, --help Print help infomation -d, --dirpath the input files' folder path $ ^ the empty lines are removed, and I make the upper cast to lower character. The least, I add a comma token beteewn the `-short` flag and `--long flag`
update from the origin
for a better output (I think)
|
Not sure why this PR is not blocked, but it should be. This change fails the build. |
I find that if the sub-command part is empty the origin will add a newline token still - but it is not what I want! so I compare the length to check if I should add the newline character.
fix a bug from peterlits
|
Hi, akamensky, |
|
Hi, akamensky, It do be better! Thanks. |
|
Hi, akamensky, |
the description should be have the two-whitespace indent but not three
fix to make it can run test succuesly
|
Hi, akamensky, |
change the way to show the usage
let it works in test
let the [sub]Command has its newline (to make it looks better)
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Thank you for your contributions. Feel free to comment or otherwise update to keep it alive. |
|
Closing due to old age. Feel free to re-open or ping maintainers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I change the way to print the usage! I think it will be better! Do you think so?