Fix a few colors to make this look more like Atom

[emroussel]

I use this theme and added a couple color customizations in my settings to make a couple small things look more like Atom, and thought I'd share them here.

I'm happy to discuss or make changes if you spot something I didn't, or feel like some changes aren't appropriate.

Changes:

"editor.findMatchHighlightBackground": "#314166",
"editor.foreground": "#ABB2C0",
"editorWidget.border": "#373D48",
"editorLineNumber.activeForeground": "#777D88",
"editorLineNumber.foreground": "#4B5365",
"editorRuler.foreground": "#abb2bf26",
"tab.activeForeground": "#D7DAE0"

With before/after and Atom screenshots:

"editor.findMatchHighlightBackground": "#314166"

VSCode (before)

Atom

VSCode (after)

--

"editor.foreground": "#ABB2C0"

VSCode (before)

Atom

VSCode (after)

--

"editorWidget.border": "#373D48"

VSCode (before)

Atom
No Atom equivalent, but this color fits better into Atom's color palette

VSCode (after)

--

"editorLineNumber.activeForeground": "#777D88"

VSCode (before)

Atom

VSCode (after)

--

"editorLineNumber.foreground": "#4B5365"

VSCode (before)

Atom

VSCode (after)

--

"editorRuler.foreground": "#abb2bf26"

VSCode (before)

Atom

VSCode (after)

--

"tab.activeForeground": "#D7DAE0"

VSCode (before)

Atom

VSCode (after)

[akamud]

Wow, this is the kind of PR that makes open source totally worth it. ❤️
Thank you for your contribution, I also maintain the One Light theme, so I'll be merging your changes as soon as I replicate them to the light theme.

Thank you!

[emroussel]

@akamud any updates on this?

[akamud]

I'm so sorry for taking so long, I still haven't got the time to make a new release. I plan to work on it this weekend.

[emroussel]

No worries, thanks!

[matthew-e-brown]

@akamud any plans/updates on merging this? Thanks!

[emroussel]

@matthew-e-brown I ended up creating a new theme with those changes (+ more) because I wasn't sure if this repo is still maintained. Still happy to see this PR getting merged, but feel free to use Atomize if you want to have these changes now and (in my opinion) a more atom like experience: https://github.com/emroussel/atomize

[matthew-e-brown]

@emroussel Fantastic! Thanks. Will check it out.

[akamud]

Hi everyone, indeed I haven't use VSCode for a while now (doing stuff on JetBrains Rider atm), that's why I didn't put much effort into maintaining this project anymore. I can't just accept the PR because I generate the theme automatically and directly from the Atom One Dark Syntax. So any PR I accept would be overridden, what I need to do is replicate the changes to my generator. I'm sorry about that.

Please remember that VSCode allows for any customization to be applied on top of any theme, like I mention in the README, so that takes away the burden of releasing new versions so frequently.

About forks, I use a MIT license exactly to allow anyone to keep on going from where I stopped. Just remember that MIT requires you to reference the original copyright. I see a lot of forks from this theme that just ignores this completely and is, therefore, breaking the license.

[akamud]

Thank you again for your contributions, all your fixes are released in 2.2.0.