Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join() の改善 #14

Closed
akanehara opened this issue Feb 18, 2013 · 2 comments
Closed

join() の改善 #14

akanehara opened this issue Feb 18, 2013 · 2 comments

Comments

@akanehara
Copy link
Owner

Ginq::join() がルックアップテーブルを作るのは、Ginq::join() 実行時ではなく、イテレータの riwind() であるべき。クエリを組み立てるだけで inner の全件走査が動作するのはできる限り実行を遅延するGinqのポリシーに反する。join を selectMany の再利用で実装するのをやめ、専用のイテレータを作る。
@akanehara
Copy link
Owner Author

JoinIterator が SelectManyWithIterator を再利用する、で実現できそう。

akanehara added a commit that referenced this issue Feb 19, 2013
@akanehara
#14 fixed
5126426
@akanehara
Copy link
Owner Author

手動クローズ。PhpStormから fixed #14 とやったはずなのにコミットコメントがなぜか空…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akanehara