Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added bhagavad-geeta-card #41

Merged
merged 2 commits into from
Oct 6, 2023
Merged

added bhagavad-geeta-card #41

merged 2 commits into from
Oct 6, 2023

Conversation

piyushkdas0611
Copy link
Contributor

@piyushkdas0611 piyushkdas0611 commented Oct 6, 2023 •
edited by akanshSirohi

Screenshot (10)

closes #38

akanshSirohi
akanshSirohi requested changes Oct 6, 2023
View reviewed changes
Copy link
Owner

@akanshSirohi akanshSirohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more quotes...?

src/data/bhagavad_geeta_quotes.json
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More quotes required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50 quotes are good enough?

@akanshSirohi akanshSirohi added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 6, 2023
@akanshSirohi akanshSirohi merged commit 70b606c into akanshSirohi:master Oct 6, 2023
@akanshSirohi
Copy link
Owner

@piyushkdas0611 Your card is live now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akanshSirohi akanshSirohi akanshSirohi approved these changes

Assignees

@piyushkdas0611 piyushkdas0611

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a Bhagavad Geeta Quotes Card
2 participants
@piyushkdas0611 @akanshSirohi