Wrote new classes NewsConn, DerivConn, DerivativeInfo, new examples.py and more #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ines and news config settings. Still need to implement getting full news stories from headline ids as well as getting news story counts, but getting config and headlines is working so far.
…lso timing out when dtn servers had too much load, so added some code that waits exactly the amount of time it takes for iqfeed to make a port available
…ice.launch on linux, added new listeners, and more
|
Thanks for the fantastic work. Will be doing some extensive testing today. |
|
Hey Ashwin, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check revision history for full story, these changes represent several days of coding and testing.
I was careful to add copius and generous comments when appropriate to explain any changes that were made.
Here are a few highlights:
-New classes: NewsConn, DerivConn and DerivativeInfo
-Added new listener classes VerboseDerivListener and SilentDerivListener to support new class
-Linux usability dramatically increased by robustification of the posix version of FeedService.launch() works great with near zero latency to connect and works great streaming across multiple Python processes all calling pyiqfeed at the same time
-New example code added to example.py to test the new classes and put everything through it's paces
-Printing slightly more verbose output for examples so it's easier to see what's going on
-Tweaked the relative import in conn.py so that documentation can be autogenerated using pydoc3.5
Good stuff. Do a code review and let me know what you think, have spent almost one full day testing this new code and all seems to be stable enough to send you a pull request.
With this update pyiqfeed should have near 100% code coverage for the DTN TCP/IP requests API! Word up.