Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up TSLint warning during build #53

Closed
jtary opened this issue Feb 24, 2023 · 2 comments · Fixed by #85
Closed

Clean up TSLint warning during build #53

jtary opened this issue Feb 24, 2023 · 2 comments · Fixed by #85
Labels
bug Something isn't working good first issue Good for newcomers sev2

Comments

@jtary
Copy link
Contributor

jtary commented Feb 24, 2023

Describe the bug
A few lining issues have cropped in involving unused variables. These should be cleaned up

To Reproduce
Steps to reproduce the behavior:

  1. Run yarn dev in the web directory

Screenshots

[0] Starting the development server...
[0] 
[0] Compiled with warnings.
[0] 
[0] [eslint] 
[0] src/components/Bid/index.tsx
[0]   Line 78:24:  Array.prototype.map() expects a value to be returned at the end of arrow function  array-callback-return
[0] 
[0] src/components/PlaceholderCard/index.tsx
[0]   Line 1:10:  'Button' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/components/SdlConfiguration/EnvironmentVariable.tsx
[0]   Line 1:29:  'FormikValues' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/components/SdlConfiguration/Ports.tsx
[0]   Line 4:23:  'Grid' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/components/WalletDeployButton/index.tsx
[0]   Line 122:7:  'Recommended' is assigned a value but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/hooks/useAppCache.ts
[0]   Line 1:8:  'React' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/hooks/useWallet.ts
[0]   Line 3:10:  'KeplrWallet' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/index.tsx
[0]   Line 10:10:  'ReactQueryDevtools' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/pages/FeaturedApps.tsx
[0]   Line 11:7:  'LightIcon' is assigned a value but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/pages/PreflightCheck.tsx
[0]   Line 8:41:   'loadActiveCertificate' is defined but never used  @typescript-eslint/no-unused-vars
[0]   Line 13:10:  'getKeplr' is defined but never used               @typescript-eslint/no-unused-vars
[0]   Line 18:17:  'setKeplr' is assigned a value but never used      @typescript-eslint/no-unused-vars
[0] 
[0] src/pages/SelectApp.tsx
[0]   Line 3:18:  'Box' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/pages/UpdateDeployment.tsx
[0]   Line 23:10:  'Manifest' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/style/mui-theme.ts
[0]   Line 1:23:  'PaletteOptions' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] Search for the keywords to learn more about each warning.
[0] To ignore, add // eslint-disable-next-line to the line before.
[0] 
[0] WARNING in [eslint] 
[0] src/components/Bid/index.tsx
[0]   Line 78:24:  Array.prototype.map() expects a value to be returned at the end of arrow function  array-callback-return
[0] 
[0] src/components/PlaceholderCard/index.tsx
[0]   Line 1:10:  'Button' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/components/SdlConfiguration/EnvironmentVariable.tsx
[0]   Line 1:29:  'FormikValues' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/components/SdlConfiguration/Ports.tsx
[0]   Line 4:23:  'Grid' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/components/WalletDeployButton/index.tsx
[0]   Line 122:7:  'Recommended' is assigned a value but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/hooks/useAppCache.ts
[0]   Line 1:8:  'React' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/hooks/useWallet.ts
[0]   Line 3:10:  'KeplrWallet' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/index.tsx
[0]   Line 10:10:  'ReactQueryDevtools' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/pages/FeaturedApps.tsx
[0]   Line 11:7:  'LightIcon' is assigned a value but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/pages/PreflightCheck.tsx
[0]   Line 8:41:   'loadActiveCertificate' is defined but never used  @typescript-eslint/no-unused-vars
[0]   Line 13:10:  'getKeplr' is defined but never used               @typescript-eslint/no-unused-vars
[0]   Line 18:17:  'setKeplr' is assigned a value but never used      @typescript-eslint/no-unused-vars
[0] 
[0] src/pages/SelectApp.tsx
[0]   Line 3:18:  'Box' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/pages/UpdateDeployment.tsx
[0]   Line 23:10:  'Manifest' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] src/style/mui-theme.ts
[0]   Line 1:23:  'PaletteOptions' is defined but never used  @typescript-eslint/no-unused-vars
[0] 
[0] webpack compiled with 1 warning
[0] No issues found.
@jtary jtary added bug Something isn't working sev2 good first issue Good for newcomers and removed product/console labels Feb 24, 2023
@SudhanshuKumar9
Copy link

Hi,
I have fixed all build warnings by cleaning all unused properties.
I've created a PR for this as well #84

@jtary jtary closed this as completed in #85 Mar 24, 2023
jtary pushed a commit that referenced this issue Mar 24, 2023
- removed unnecessary variables and imports
- returned null otherwise for the map function however we could also use forEach instead

fixes #53
github-actions bot pushed a commit that referenced this issue Mar 24, 2023
- removed unnecessary variables and imports
- returned null otherwise for the map function however we could also use forEach instead

fixes #53 0.1.254
@Bharat-2000
Copy link

Hey i have gone through the issue and there are still 3-4 active console warnings. Let me contribute to the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers sev2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants