Updated dependencies and webpack configs to reproduce bug

akash5474 · Jun 19, 2018 · 764c1be · 764c1be
1 parent ca2aa8a
commit 764c1be
Show file tree

Hide file tree

Showing 8 changed files with 12,192 additions and 6,440 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -22,7 +22,7 @@
     "react-dom": "^16.0.0",
     "react-universal-component": "^2.5.1",
     "webpack-dev-middleware": "^1.11.0",
-    "webpack-flush-chunks": "^1.1.23"
+    "webpack-flush-chunks": "^2.0.0"
   },
   "devDependencies": {
     "babel-cli": "^6.24.0",
@@ -44,7 +44,7 @@
     "eslint-plugin-import": "^2.2.0",
     "eslint-plugin-jsx-a11y": "^6.0.2",
     "eslint-plugin-react": "^7.4.0",
-    "extract-css-chunks-webpack-plugin": "^2.0.17",
+    "extract-css-chunks-webpack-plugin": "^3.0.5",
     "husky": "^0.14.3",
     "lint-staged": "^4.2.3",
     "poststylus": "^1.0.0",
@@ -54,7 +54,7 @@
     "stylus": "^0.54.5",
     "stylus-loader": "^3.0.1",
     "travis-github-status": "^1.4.0",
-    "webpack": "^3.5.1",
+    "webpack": "^4.12.0",
     "webpack-hot-middleware": "^2.17.1",
     "webpack-hot-server-middleware": "^0.1.0",
     "write-file-webpack-plugin": "^4.1.0"

diff --git a/src/index.js b/src/index.js
@@ -6,6 +6,8 @@ import App from './components/App'
 
 const history = createHistory()
 
+console.log('hello world')
+
 const render = App =>
   ReactDOM.hydrate(
     <AppContainer>

diff --git a/webpack/client.dev.js b/webpack/client.dev.js
@@ -28,20 +28,19 @@ module.exports = {
       },
       {
         test: /\.styl$/,
-        use: ExtractCssChunks.extract({
-          use: [
-            {
-              loader: 'css-loader',
-              options: {
-                modules: true,
-                localIdentName: '[name]__[local]--[hash:base64:5]'
-              }
-            },
-            {
-              loader: 'stylus-loader'
+        use: [
+          ExtractCssChunks.loader,
+          {
+            loader: 'css-loader',
+            options: {
+              modules: true,
+              localIdentName: '[name]__[local]--[hash:base64:5]'
             }
-          ]
-        })
+          },
+          {
+            loader: 'stylus-loader'
+          }
+        ]
       }
     ]
   },
@@ -51,18 +50,16 @@ module.exports = {
   plugins: [
     new WriteFilePlugin(),
     new ExtractCssChunks(),
-    new webpack.optimize.CommonsChunkPlugin({
-      names: ['bootstrap'], // needed to put webpack bootstrap code before chunks
-      filename: '[name].js',
-      minChunks: Infinity
-    }),
-
-    new webpack.HotModuleReplacementPlugin(),
-    new webpack.NoEmitOnErrorsPlugin(),
     new webpack.DefinePlugin({
       'process.env': {
         NODE_ENV: JSON.stringify('development')
       }
     })
-  ]
+  ],
+
+  optimization: {
+    runtimeChunk: {
+      name: 'bootstrap'
+    }
+  }
 }
diff --git a/webpack/client.prod.js b/webpack/client.prod.js
@@ -22,20 +22,19 @@ module.exports = {
       },
       {
         test: /\.styl$/,
-        use: ExtractCssChunks.extract({
-          use: [
-            {
-              loader: 'css-loader',
-              options: {
-                modules: true,
-                localIdentName: '[name]__[local]--[hash:base64:5]'
-              }
-            },
-            {
-              loader: 'stylus-loader'
+        use: [
+          ExtractCssChunks.loader,
+          {
+            loader: 'css-loader',
+            options: {
+              modules: true,
+              localIdentName: '[name]__[local]--[hash:base64:5]'
             }
-          ]
-        })
+          },
+          {
+            loader: 'stylus-loader'
+          }
+        ]
       }
     ]
   },
@@ -44,31 +43,17 @@ module.exports = {
   },
   plugins: [
     new ExtractCssChunks(),
-    new webpack.optimize.CommonsChunkPlugin({
-      names: ['bootstrap'], // needed to put webpack bootstrap code before chunks
-      filename: '[name].[chunkhash].js',
-      minChunks: Infinity
-    }),
 
     new webpack.DefinePlugin({
       'process.env': {
         NODE_ENV: JSON.stringify('production')
       }
-    }),
-    new webpack.optimize.UglifyJsPlugin({
-      compress: {
-        screw_ie8: true,
-        warnings: false
-      },
-      mangle: {
-        screw_ie8: true
-      },
-      output: {
-        screw_ie8: true,
-        comments: false
-      },
-      sourceMap: true
-    }),
-    new webpack.HashedModuleIdsPlugin() // not needed for strategy to work (just good practice)
-  ]
+    })
+  ],
+
+  optimization: {
+    runtimeChunk: {
+      name: 'bootstrap'
+    }
+  }
 }
diff --git a/webpack/server.dev.js b/webpack/server.dev.js
@@ -32,7 +32,7 @@ module.exports = {
   externals,
   output: {
     path: output,
-    filename: '[name].js',
+    filename: 'main.js',
     libraryTarget: 'commonjs2'
   },
   module: {

diff --git a/webpack/server.prod.js b/webpack/server.prod.js
@@ -13,7 +13,7 @@ module.exports = {
   entry: [entry],
   output: {
     path: output,
-    filename: '[name].js',
+    filename: 'main.js',
     libraryTarget: 'commonjs2'
   },
   module: {