use findOrFail for dashboard

akaunting · Nov 2, 2020 · 24a5e8a · 24a5e8a
1 parent 61ee01a
commit 24a5e8a
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/app/Http/Controllers/Common/Dashboards.php b/app/Http/Controllers/Common/Dashboards.php
@@ -13,6 +13,7 @@
 use App\Traits\DateTime;
 use App\Traits\Users;
 use App\Utilities\Widgets;
+use Illuminate\Database\Eloquent\ModelNotFoundException;
 
 class Dashboards extends Controller
 {
@@ -51,9 +52,9 @@ public function show($dashboard_id = null)
     {
         $dashboard_id = $dashboard_id ?? session('dashboard_id');
 
-        if (!empty($dashboard_id)) {
-            $dashboard = Dashboard::find($dashboard_id);
-        } else {
+        try {
+            $dashboard = Dashboard::findOrFail($dashboard_id);
+        } catch (ModelNotFoundException $e) {
             $dashboard = user()->dashboards()->enabled()->first();
         }