close #191 Fixed : When trying to edit Companies. it is broken

akaunting · Jan 16, 2018 · 75531ee · 75531ee · sebadamus · Jan 16, 2018
1 parent 3d2122e
commit 75531ee
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 34 deletions.
diff --git a/app/Listeners/Updates/Version119.php b/app/Listeners/Updates/Version119.php
@@ -92,20 +92,30 @@ public function handle(UpdateFinished $event)
             $items = $data[basename($model)];
 
             foreach ($items as $item) {
-                if ($item->$name) {
-                    $path = explode('uploads/', $item->$name);
+                if (!$item->$name) {
+                    continue;
+                }
 
-                    $path = end($path);
+                $path = explode('uploads/', $item->$name);
 
-                    if (!empty($item->company_id) && (strpos($path, $item->company_id . '/') === false)) {
-                        $path = $item->company_id . '/' . $path;
-                    }
+                $path = end($path);
 
-                    if (!empty($path) && Storage::exists($path)) {
-                        $media = MediaUploader::importPath(config('mediable.default_disk'), $path);
+                if (!empty($item->company_id) && (strpos($path, $item->company_id . '/') === false)) {
+                    $path = $item->company_id . '/' . $path;
+                }
+
+                if (!empty($path) && Storage::exists($path)) {
+                    $media = \App\Models\Common\Media::where('filename', '=', pathinfo(basename($path), PATHINFO_FILENAME))->first();
 
+                    if ($media) {
                         $item->attachMedia($media, $name);
+
+                        continue;
                     }
+
+                    $media = MediaUploader::importPath(config('mediable.default_disk'), $path);
+
+                    $item->attachMedia($media, $name);
                 }
             }
         }
@@ -115,34 +125,36 @@ public function handle(UpdateFinished $event)
 
         foreach ($settings as $name => $items) {
             foreach ($items as $item) {
-                if ($item->value) {
-                    $path = explode('uploads/', $item->value);
+                if (!$item->value) {
+                    continue;
+                }
 
-                    $path = end($path);
+                $path = explode('uploads/', $item->value);
 
-                    if (!empty($item->company_id) && (strpos($path, $item->company_id . '/') === false)) {
-                        $path = $item->company_id . '/' . $path;
-                    }
+                $path = end($path);
 
-                    if (!empty($path) && Storage::exists($path)) {
-                        $company = \App\Models\Company\Company::find($item->company_id);
+                if (!empty($item->company_id) && (strpos($path, $item->company_id . '/') === false)) {
+                    $path = $item->company_id . '/' . $path;
+                }
+
+                if (!empty($path) && Storage::exists($path)) {
+                    $company = \App\Models\Company\Company::find($item->company_id);
 
-                        $media = \App\Models\Common\Media::where('filename', '=',  pathinfo(basename($path), PATHINFO_FILENAME))->first();
+                    $media = \App\Models\Common\Media::where('filename', '=', pathinfo(basename($path), PATHINFO_FILENAME))->first();
 
-                        if ($company && !$media) {
-                            $media = MediaUploader::importPath(config('mediable.default_disk'), $path);
+                    if ($company && !$media) {
+                        $media = MediaUploader::importPath(config('mediable.default_disk'), $path);
 
-                            $company->attachMedia($media, $name);
+                        $company->attachMedia($media, $name);
 
-                            $item->update(['value' => $media->id]);
-                        } elseif ($media) {
-                            $item->update(['value' => $media->id]);
-                        } else {
-                            $item->update(['value' => '']);
-                        }
+                        $item->update(['value' => $media->id]);
+                    } elseif ($media) {
+                        $item->update(['value' => $media->id]);
                     } else {
                         $item->update(['value' => '']);
                     }
+                } else {
+                    $item->update(['value' => '']);
                 }
             }
         }

diff --git a/app/Models/Company/Company.php b/app/Models/Company/Company.php
@@ -236,14 +236,8 @@ public function emailSortable($query, $direction)
      *
      * @return string
      */
-    public function getCompanyLogoAttribute($value)
+    public function getCompanyLogoAttribute()
     {
-        if (!empty($value) && !$this->hasMedia('company_logo')) {
-            return $value;
-        } elseif (!$this->hasMedia('company_logo')) {
-            return false;
-        }
-
         return $this->getMedia('company_logo')->last();
     }
 }
diff --git a/public/css/app.css b/public/css/app.css
@@ -537,4 +537,9 @@ ul.add-new.nav.navbar-nav.pull-left {
     clear: both;
     margin-top: 25px;
     margin-bottom: 10px;
-}
+}
+
+span.picture, span.attachment {
+    margin-left: 10px;
+    vertical-align: middle;
+}