added transaction number interface

akaunting · May 15, 2023 · 7a3aa98 · 7a3aa98
1 parent c8a5127
commit 7a3aa98
Show file tree

Hide file tree

Showing 5 changed files with 65 additions and 28 deletions.
diff --git a/app/Http/Controllers/Banking/Transactions.php b/app/Http/Controllers/Banking/Transactions.php
@@ -101,7 +101,7 @@ public function create()
         $type = request()->get('type', 'income');
         $real_type = $this->getRealTypeTransaction($type);
 
-        $number = $this->getNextTransactionNumber();
+        $number = $this->getNextTransactionNumber($type);
 
         $contact_type = config('type.transaction.' . $type . '.contact_type');
 

diff --git a/app/Interfaces/Utility/TransactionNumber.php b/app/Interfaces/Utility/TransactionNumber.php
@@ -0,0 +1,12 @@
+<?php
+
+namespace App\Interfaces\Utility;
+
+use App\Models\Common\Contact;
+
+interface TransactionNumber
+{
+    public function getNextNumber(string $type, string $suffix, ?Contact $contact): string;
+
+    public function increaseNextNumber(string $type, string $suffix, ?Contact $contact): void;
+}
diff --git a/app/Providers/Binding.php b/app/Providers/Binding.php
@@ -3,7 +3,9 @@
 namespace App\Providers;
 
 use App\Interfaces\Utility\DocumentNumber as DocumentNumberInterface;
+use App\Interfaces\Utility\TransactionNumber as TransactionNumberInterface;
 use App\Utilities\DocumentNumber;
+use App\Utilities\TransactionNumber;
 use Illuminate\Support\ServiceProvider;
 
 class Binding extends ServiceProvider
@@ -15,5 +17,6 @@ class Binding extends ServiceProvider
      */
     public array $bindings = [
         DocumentNumberInterface::class => DocumentNumber::class,
+        TransactionNumberInterface::class => TransactionNumber::class,
     ];
 }
diff --git a/app/Traits/Transactions.php b/app/Traits/Transactions.php
@@ -4,6 +4,7 @@
 
 use App\Events\Banking\TransactionPrinting;
 use App\Models\Banking\Transaction;
+use App\Interfaces\Utility\TransactionNumber;
 use Illuminate\Support\Str;
 
 trait Transactions
@@ -228,36 +229,13 @@ public function getRealTypeOfSplitTransaction(string $transfer_type): string
         return Str::replace('-split', '', $transfer_type);
     }
 
-    public function getNextTransactionNumber($suffix = ''): string
+    public function getNextTransactionNumber($type = 'income', $suffix = ''): string
     {
-        $prefix = setting('transaction' . $suffix . '.number_prefix');
-        $next   = (string) setting('transaction' . $suffix . '.number_next');
-        $digit  = (int) setting('transaction' . $suffix . '.number_digit');
-
-        $get_number = fn($prefix, $next, $digit) => $prefix . str_pad($next, $digit, '0', STR_PAD_LEFT);
-        $number_exists = fn($number) => Transaction::where('number', $number)->exists();
-
-        $transaction_number = $get_number($prefix, $next, $digit);
-
-        if ($number_exists($transaction_number)) {
-            do {
-                $next++;
-
-                $transaction_number = $get_number($prefix, $next, $digit);
-            } while ($number_exists($transaction_number));
-
-            setting(['transaction' . $suffix . '.number_next' => $next]);
-            setting()->save();
-        }
-
-        return $transaction_number;
+        return app(TransactionNumber::class)->getNextNumber($type, $suffix, null);
     }
 
-    public function increaseNextTransactionNumber($suffix = ''): void
+    public function increaseNextTransactionNumber($type = 'income', $suffix = ''): void
     {
-        $next = setting('transaction' . $suffix . '.number_next', 1) + 1;
-
-        setting(['transaction' . $suffix . '.number_next' => $next]);
-        setting()->save();
+        app(TransactionNumber::class)->increaseNextNumber($type, $suffix, null);
     }
 }
diff --git a/app/Utilities/TransactionNumber.php b/app/Utilities/TransactionNumber.php
@@ -0,0 +1,44 @@
+<?php
+
+namespace App\Utilities;
+
+use App\Interfaces\Utility\TransactionNumber as TransactionNumberInterface;
+use App\Models\Banking\Transaction;
+use App\Models\Common\Contact;
+
+class TransactionNumber implements TransactionNumberInterface
+{
+    public function getNextNumber($suffix = '', ?Contact $contact): string
+    {
+        $prefix = setting('transaction' . $suffix . '.number_prefix');
+        $next   = (string) setting('transaction' . $suffix . '.number_next');
+        $digit  = (int) setting('transaction' . $suffix . '.number_digit');
+
+        $get_number = fn($prefix, $next, $digit) => $prefix . str_pad($next, $digit, '0', STR_PAD_LEFT);
+        $number_exists = fn($number) => Transaction::where('number', $number)->exists();
+
+        $transaction_number = $get_number($prefix, $next, $digit);
+
+        if ($number_exists($transaction_number)) {
+            do {
+                $next++;
+
+                $transaction_number = $get_number($prefix, $next, $digit);
+            } while ($number_exists($transaction_number));
+
+            setting(['transaction' . $suffix . '.number_next' => $next]);
+            setting()->save();
+        }
+
+        return $transaction_number;
+
+    }
+
+    public function increaseNextNumber($suffix = '', ?Contact $contact): void
+    {
+        $next = setting('transaction' . $suffix . '.number_next', 1) + 1;
+
+        setting(['transaction' . $suffix . '.number_next' => $next]);
+        setting()->save();
+    }
+}