Refactor duplicated variables

akaunting · Jul 2, 2021 · 8f27089 · 8f27089
1 parent 165f857
commit 8f27089
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/resources/assets/js/views/common/items.js b/resources/assets/js/views/common/items.js
@@ -34,7 +34,8 @@
                  '.,',
                  ',.',
                  ',,'
-             ]
+             ],
+             splice_value: null
          }
      },
 
@@ -46,13 +47,11 @@
                  this.form.sale_price = oldVal;
              }
 
-             let splice_value;
-
              if (newVal.search('^(?=.*?[0-9])[0-9.,]+$') == 0) {
                  for (let item of this.regex_condition) {
                      if (this.form.sale_price.includes(item)) {
-                        splice_value = this.form.sale_price.replace(item, '');
-                        this.form.sale_price = splice_value;
+                        this.splice_value = this.form.sale_price.replace(item, '');
+                        this.form.sale_price = this.splice_value;
                      }
                  }
              }
@@ -63,13 +62,11 @@
                  this.form.purchase_price = oldVal;
              }
 
-             let splice_value;
-
              if (newVal.search('^(?=.*?[0-9])[0-9.,]+$') == 0) {
                 for (let item of this.regex_condition) {
                     if (this.form.purchase_price.includes(item)) {
-                       splice_value = this.form.purchase_price.replace(item, '');
-                       this.form.purchase_price = splice_value;
+                        this.splice_value = this.form.purchase_price.replace(item, '');
+                       this.form.purchase_price = this.splice_value;
                     }
                 }
             }