Delete attachment's file on disk

akaunting · Jun 17, 2021 · 9dd1c92 · 9dd1c92
1 parent 873d25c
commit 9dd1c92
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/app/Http/Controllers/Common/Uploads.php b/app/Http/Controllers/Common/Uploads.php
@@ -27,11 +27,11 @@ public function get($id)
         }
 
         // Get file path
-        if (!$path = $this->getMediaPathOnStorage($media)) {
+        if (!$this->getMediaPathOnStorage($media)) {
             return response(null, 204);
         }
 
-        return $this->streamMedia($media, $path);
+        return $this->streamMedia($media);
     }
 
     /**
@@ -70,7 +70,7 @@ public function show($id, Request $request)
         }
 
         // Get file path
-        if (!$path = $this->getMediaPathOnStorage($media)) {
+        if (!$this->getMediaPathOnStorage($media)) {
             return response()->json([
                 'success' => false,
                 'error'   => true,
@@ -108,11 +108,11 @@ public function download($id)
         }
 
         // Get file path
-        if (!$path = $this->getMediaPathOnStorage($media)) {
+        if (!$this->getMediaPathOnStorage($media)) {
             return false;
         }
 
-        return $this->streamMedia($media, $path);
+        return $this->streamMedia($media);
     }
 
     /**

diff --git a/app/Traits/Uploads.php b/app/Traits/Uploads.php
@@ -100,10 +100,10 @@ public function getMediaPathOnStorage($media)
             return false;
         }
 
-        return Storage::path($path);
+        return $path;
     }
 
-    public function streamMedia($media, $path = '')
+    public function streamMedia($media)
     {
         return response()->streamDownload(
             function() use ($media) {