make sure module exists

akaunting · May 28, 2020 · ad51d61 · ad51d61
1 parent 3c0badc
commit ad51d61
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/app/Utilities/Updater.php b/app/Utilities/Updater.php
@@ -164,7 +164,17 @@ public static function all()
         $versions = Versions::all($modules);
 
         foreach ($versions as $alias => $latest_version) {
-            $installed_version = ($alias == 'core') ? version('short') : module($alias)->get('version');
+            if ($alias == 'core') {
+                $installed_version = version('short');
+            } else {
+                $module = module($alias);
+
+                if (!$module instanceof \Akaunting\Module\Module) {
+                    continue;
+                }
+
+                $installed_version = $module->get('version');
+            }
 
             if (version_compare($installed_version, $latest_version, '>=')) {
                 continue;

diff --git a/app/Utilities/Versions.php b/app/Utilities/Versions.php
@@ -2,7 +2,6 @@
 
 namespace App\Utilities;
 
-use Akaunting\Module\Module;
 use App\Traits\SiteApi;
 use Cache;
 use Date;
@@ -89,7 +88,7 @@ public static function all($modules = null)
                 $module = module($module);
             }
 
-            if (!$module instanceof Module) {
+            if (!$module instanceof \Akaunting\Module\Module) {
                 continue;
             }