Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Modal Info shows up on every page #2856

Closed
mrtn3000 opened this issue Jan 2, 2023 · 2 comments
Closed

Firefox Modal Info shows up on every page #2856

mrtn3000 opened this issue Jan 2, 2023 · 2 comments
Labels
Milestone

Comments

@mrtn3000
Copy link

mrtn3000 commented Jan 2, 2023

Akaunting version

3.0.10

PHP version

8.1

Operating system

Ubuntu 20.04

Steps to reproduce

First, thanks for developing and sharing akaunting with the world!
I've installed it a few days ago through the digital ocean marketplace and so far really like it.
I noticed this small, but anoying issue with the "Firefox Icon Configuration" modal dialog.
So far I have logged in with default user/password on Firefox and made some adjustments to the settings (only via the web ui)
Now, on every new site load I get the model dialog informing me about changes I could make to my firefox settings (although everything seems to work fine)

Expected result

Dialog should only show up once. In the best case it should only show up when the issue actually exists.

Actual result

The dialog pops up on every page.

Additional comments

This line is not testing any status (if it has been shown or acknowledged before)

if (navigator.userAgent.search("Firefox") >= 0) {

Relevant log output

-
@atiabjobayer
Copy link

Same issue! Someone please help.

@cuneytsenturk cuneytsenturk added this to the 3.0.11 milestone Jan 3, 2023
@dadeke
Copy link
Contributor

dadeke commented Jan 3, 2023

The expires of the firefoxCookieModal is constant:

    function delete_cookie() {
        document.cookie = 'firefoxCookieModal=true; expires=Thu, 1 Jan 2023 00:00:01 GMT;';
        document.querySelector('[data-cookie-modal]').remove();
    }

"Thu, 1 Jan 2023 00:00:01 GMT" 🤔

Maybe change this to:

    function delete_cookie() {
        document.cookie = 'firefoxCookieModal=true; expires=Fri, 1 Jan 9999 00:00:01 GMT;';
        document.querySelector('[data-cookie-modal]').remove();
    }

cuneytsenturk added a commit that referenced this issue Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants