Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with inclusive tax calculation #688

Closed
sausin opened this issue Dec 20, 2018 · 1 comment
Closed

Issues with inclusive tax calculation #688

sausin opened this issue Dec 20, 2018 · 1 comment
Labels
Milestone

Comments

@sausin
Copy link
Contributor

sausin commented Dec 20, 2018

Steps to reproduce the issue

  1. Create two tax rates (inclusive type, for eg 5%)
  2. Create a bill (for eg. $110)
  3. Add two inclusive rates
  4. See tax calculation

Expected result

Expect to see tax of $10 in total ($5 corresponding to each tax slab) and subtotal of $100

Actual result

Only half the tax is calculated and that too is incorrectly calculated.

System information (Akaunting, PHP versions)

Akaunting - 1.3.4
PHP - 7.2.10

Additional comments

image

The tax calculation should sum up all the rates for inclusive type and calculate the base price. The taxes should then be calculated over this base price and also be summed together.

@sausin
Copy link
Contributor Author

sausin commented Dec 20, 2018

As an additional comment, there should probably be a limitation on different tax types being used together. For eg. if inclusive and normal type tax types are added - it would be a bit of a mess wrt calculation of base price

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants