Update popover function call method signature #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently on line #275 `$('a[rel=popover]').popover({ html: 'true',` html true where `'true'` is within quotes, Which causes issue when trying to open popover. As popover expects Boolean. As mentioned at: https://github.com/akaunting/akaunting/issues/url
|
Thanks @shreyansh9226 Could you fix those pages Bill, Invoice create and edit template, I'll merge if you send those changes. |
Fixed: Calling popover with html variable under quotes.
Fixed: Calling popover with html variable under quotes.
Fixed: Calling popover with html variable under quotes.
|
@cuneytsenturk Hi, Sorry for the delay. But its done. |
|
Thank you @shreyansh9226 |
ihsanberahim
pushed a commit
to ihsanberahim/akaunting
that referenced
this pull request
Jul 3, 2023
Bumps [composer/composer](https://github.com/composer/composer) from 2.0.11 to 2.0.13. - [Release notes](https://github.com/composer/composer/releases) - [Changelog](https://github.com/composer/composer/blob/master/CHANGELOG.md) - [Commits](composer/composer@2.0.11...2.0.13) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on line #275
$('a[rel=popover]').popover({ html: 'true',html true where
'true'is within quotes, Which causes issue when trying to open popover. As popover expects Boolean. As mentioned at: https://getbootstrap.com/docs/4.0/components/popovers/#options