Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calculation to show correct amount in modal #689

Merged
merged 1 commit into from
Dec 25, 2018
Merged

Fix calculation to show correct amount in modal #689

merged 1 commit into from
Dec 25, 2018

Conversation

sausin
Copy link
Contributor

@sausin sausin commented Dec 20, 2018

Fix grand_total calculation. No $paid variable existed

@sausin
Update BillPayments.php
4a67b52 
Fix `grand_total` calculation. No $paid variable existed
@sausin
Copy link
Contributor Author

sausin commented Dec 20, 2018

While I've updated the code to not change the method, I think the if condition is not really useful. The method in the class will return 0 if there is no paid amount, making the if condition redundant

@cuneytsenturk cuneytsenturk added this to the 1.3.5 milestone Dec 25, 2018
@cuneytsenturk cuneytsenturk merged commit 592fe71 into akaunting:master Dec 25, 2018
@cuneytsenturk
Copy link
Member

Thank you @sausin

@sausin sausin deleted the patch-1 branch December 25, 2018 13:51
@sausin
Copy link
Contributor Author

sausin commented Dec 25, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sausin @cuneytsenturk