Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make <waiting-indicator> an singleton which you send messages to activate, rather than with the waiting property #52

Closed
akc42 opened this issue Aug 29, 2020 · 0 comments
Assignees
Labels
Enhancement Improve an existing facility so it works better

Comments

@akc42
Copy link
Owner

akc42 commented Aug 29, 2020

An optimisation thing. We don't need multiple waiting indicators around the dom when one will do.

Note - I am not sure whether to latch the event onto the window or bubble up the dom. I am inclined to the latter as in future it gives flexibility to have more than one in the dom with different visual appearences.

@akc42 akc42 added the Enhancement Improve an existing facility so it works better label Aug 29, 2020
@akc42 akc42 added this to the v4.0.0-alpha14 milestone Aug 29, 2020
@akc42 akc42 self-assigned this Aug 29, 2020
@akc42 akc42 added this to To do in Weekly Sprint via automation Aug 29, 2020
@akc42 akc42 moved this from To do to In progress in Weekly Sprint Aug 29, 2020
@akc42 akc42 closed this as completed Aug 29, 2020
Weekly Sprint automation moved this from In progress to Done Aug 29, 2020
akc42 added a commit that referenced this issue Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve an existing facility so it works better
Projects
Weekly Sprint
  
Done
Development

No branches or pull requests

1 participant