Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppleTV installation issue and update readme with AppleTV #103

Closed
wants to merge 2 commits into from

Conversation

stuartw1
Copy link

@stuartw1 stuartw1 commented May 5, 2022

Some suggested patches for AppleTV support. Please review and feel free to ask me to improve if they are not up to standard or reject if not worth merging :)

Change 1 - pkg-actions.m

Bypass the notification window for AppleTV devices so that installation does not hang. The AppleTV can't display the notification window so installation hangs, then has to be force quit by the user. The patch attempts to resolve this, though the information could also be printed to the logs. Support for bridgeOS or watchOS etc. could be added in a similar way if required.

Change 2 README.md

Add instructions to the readme for how to build a *.deb for AppleTV by modifying the target. Encourage further development for other more obscure devices.

Warning

I performed some build testing on my limited selection of devices and it appeared to work - though recommend you test to double check before releasing

@stuartw1 stuartw1 mentioned this pull request May 5, 2022
@stuartw1 stuartw1 changed the title Fix AppleTV installation issue and update repo with AppleTV Fix AppleTV installation issue and update readme with AppleTV May 5, 2022
akemin-dayo added a commit that referenced this pull request May 11, 2022
… The notification is also now only shown if the user is installing using an APT frontend that supports the `CYDIA` environment variable, such as Cydia, Zebra, or Sileo. This completely replaces #103 and addresses #82.
@akemin-dayo
Copy link
Owner

akemin-dayo commented May 11, 2022

Thank you for your contribution!

I've made two major changes in commit SHA1 12314a6 that supercede the functionality in this PR.

  1. The CFUserNotification is now only displayed when the user is installing ASU using an APT frontend that implements the ${CYDIA} environment variable. This includes Cydia, Zebra, and Sileo to my knowledge.
  2. The CFUserNotification no longer blocks the main thread, so the installation process will not get stuck until the notification is dismissed. (This was a massive oversight on my part in the original implementation. Somehow I completely missed Apple mentioning CFUserNotificationCreateRunLoopSource in their documentation when I was reading it the first time around…)

As a result, I'll be closing this PR, but I will try and add some basic tvOS build support in the form of an alternate Makefile or something, as well as updating the documentation accordingly.

That being said though, can you try testing my latest changes on your tvOS machine? Let me know how the installation process goes, as I uh… still don't own a tvOS device ;P

@stuartw1
Copy link
Author

Thanks!

Just seen this - will try to take a look when I get a moment to take my tvOS machine out of the cupboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants