Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Symfony 4 #53

Merged
merged 4 commits into from Dec 9, 2018
Merged

Add support for Symfony 4 #53

merged 4 commits into from Dec 9, 2018

Conversation

stof
Copy link
Contributor

@stof stof commented Feb 20, 2018

No description provided.

@stof
Copy link
Contributor Author

stof commented Aug 3, 2018

@fitn @jmleroux any chance to get this merged at some point ?

Note that the CI failure is related to the compat with PHPUnit 6+, not to Symfony 4 (Travis pre-installed PHPUnit version uses PHPUnit 6 on PHP 7). I might send a PR fixing that, but only if you tell me there is still an interest into getting it merged.

@jmleroux
Copy link
Contributor

jmleroux commented Dec 5, 2018 •
edited

I might send a PR fixing that, but only if you tell me there is still an interest into getting it merged.

Thx @stof , and sorry for the delay.
What do you think about fixing the Travis in this PR?
If it is green, i'll merge it.

@jmleroux jmleroux self-assigned this Dec 5, 2018
@stof
Fix compatibility with PHPUnit 6+
9a90602 
The min version of PHPUnit supported to run tests is now 4.8.35, which
is the version adding the forward-compatibility layer.
@stof
Copy link
Contributor Author

stof commented Dec 9, 2018

@jmleroux done.

@stof
Add testing on PHP 7.1, 7.2 and 7.3 on Travis
7096908 
Testing on HHVM is removed, as phpspec is not compatible with it.
@stof
Use the Symfony PHPUnit bridge to run PHPUnit on CI
7a1a414 
The Travis PHP 5.5 image ships a version of PHPUnit with the forward
compatibility layer for namespaced classes.
@jmleroux jmleroux merged commit 4be5fda into akeneo-labs:master Dec 9, 2018
@jmleroux
Copy link
Contributor

jmleroux commented Dec 9, 2018

And it's done.
Released in v1.3.0.

Please also note that we are thinking about archiving/deprecating this repo and transfer ownership, to FoA organisation for instance. The decision is not totally clear right now and we will keep you updated ASAP.

@stof stof deleted the symfony_4 branch December 9, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmleroux jmleroux jmleroux approved these changes

Assignees

@jmleroux jmleroux

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stof @jmleroux